Hello Hugh, thank you for the pull request. Wouldn't make sense to move the null check to the beginning of the function? Otherwise sql_get_result would call with a null before your check. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1467#issuecomment-369850419

sql_get_result does not currently check the 'name' parameter and will crash in core_case_hash if this is NULL. This is also true for sql_get_connection and sql_init_con. However, these three functions are only called from within the sqlops module. I will add a check to the C-API/KEMI wrapper functions that call them (sqlops_do_query, sqlops_get_value, sqlops_is_null, etc.)? Is it needed inside sql_get_result as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1467#issuecomment-369868083

henningw approved this pull request. Thank you for the additional checks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1467#pullrequestreview-100981714

Merged and closed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1467#issuecomment-370166411

Merged #1467. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1467#event-1502611789