- added new rpc command for terminate a dialog with callid, fromtag and totag. - added new rpc command to doc and serctl is removed - added rpc return code to dlg_terminate_dlg function - added rpc return code to rpc domain reload function You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/555
-- Commit Summary --
* dialog module : new rpc function for terminate * dialog module : rpc terminate dialog doc added * domain module : added rpc return code * dialog module: fixed response * domain module : fixed response * dialog module: fixes travis error * domain module : fixed typo
-- File Changes --
M modules/dialog/dialog.c (46) M modules/dialog/doc/dialog_admin.xml (46) M modules/domain/domain_mod.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/555.patch https://github.com/kamailio/kamailio/pull/555.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555
I am going to apply manually the patched adding the new command for dialog to terminate by callid, from/to tag. I would change the name from dlg.dld_terminate_dlg in dlg.terminate_dlg.
For the rest of the patches, as they add embedded response code/text to a successful response, not data from dialogs. I would open a discussion on sr-users to decide on it, because it changes the current behaviour that is know to work and it can break many existing tools. Maybe this new behavior can be enabled by a modparam.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-204289773
Thanks Daniel. it is pleasure to add a reponse code for xml rpc by me. i want to help about it.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-204292166
First two patches are pushed in master now.
I noticed that the code was indented with whitespaces. Kamailio code uses tabs -- would be easier to apply the patches if you are going to use tabs for future patches.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-204300270
okey, i will keep in my mind. Thanks Daniel.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-204300955
For reference - the xmlrpc specs: http://xmlrpc.scripting.com/spec.html
You should open the discussion on sr-users mailing list, because you know better what you try to solve/improve with these patches. Describe what you don't like to current behaviour and the benefits after the patches, so the other users can comment and get to a solution.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-204327106
Closed #555.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#event-637237791
after IRC meeting , when success , it returns empty string is ok.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555#issuecomment-213280292
-
Daniel-Constantin Mierla -
Yasin CANER