Thanks for the patch. At quick look, it seems that the event route will be called twice in case of a dialog lifetime timeout. At line 1408 in dlg_handlers.c, the event route code is executed again after dlg_bye_all() and dlg_bye_all() executes inside the event route code. Might be an option to remove it from that place. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/246#issuecomment-121721788

The unrefs should be ok. One is done in case bye was not sent out, to destroy dialog faster, otherwise it will wait for the reply of the bye to unref and destroy dialog. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/246#issuecomment-121981196

I meant that the new code is this: ``` if(dlg_bye_all(dlg, NULL)<0) dlg_unref(dlg, 1); dlg_unref(dlg, 1); ``` --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/246#issuecomment-121982915

Hi i am using kamailio 4.4.3 but still I am facing the same issue, **event_route[dialog:end] is not exec'd on dialog terminated by dlg.end_dlg,** ,so the CDR's are not generating properly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/246#issuecomment-496834463