Module: kamailio Branch: master Commit: 99caa6c583c68f61aded4988e8a1603e78015a0a URL: https://github.com/kamailio/kamailio/commit/99caa6c583c68f61aded4988e8a1603… Author: jaybeepee &lt;jason.penton(a)gmail.com&gt; Committer: jaybeepee &lt;jason.penton(a)gmail.com&gt; Date: 2016-03-17T09:53:39+02:00 modules/ims_registrar_scscf: more efficient traversal of contacts --- Modified: modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/99caa6c583c68f61aded4988e8a1603… Patch: https://github.com/kamailio/kamailio/commit/99caa6c583c68f61aded4988e8a1603… --- diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c index d677272..41fe9f6 100644 --- a/modules/ims_registrar_scscf/save.c +++ b/modules/ims_registrar_scscf/save.c @@ -694,8 +694,12 @@ int get_number_of_valid_contacts(impurecord_t* impu) { int ret = 0; get_act_time(); for (i = 0; i < impu->num_contacts; i++) { - if (VALID_CONTACT(impu->newcontacts[i], act_time)) { - ret++; + if (impu->newcontacts[i]) { + if VALID_CONTACT(impu->newcontacts[i], act_time) + ret++; + } else { + //if we hit a null ref then we are at the end of the list. + return ret; } }