5 Sep
2012
5 Sep
'12
2:40 p.m.
Hi, I've experimented column size isues (too small) when trying to
store a double Path header in the location table. It seems that
current size is:
lib/srdb1/schema/location.xml:
<column>
<name>path</name>
<type>string</type>
<size>&uri_len;</size>
<null/>
<default><null/></default>
<description>Path Header(s) per RFC 3327</description>
</column>
It seems to become 128 which is not enough at all for two Path headers
if the URI's contain parameters.
Is it ok if I increase it to 512? any other file to touch?
Thanks a lot.
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
5 Sep
5 Sep
2:56 p.m.
New subject: Increase the size for the 'path' column in 'location' table
Am Mittwoch, 5. September 2012, 13:40:18 schrieb Iñaki Baz Castillo:
Hi, I've experimented column size isues (too
small) when trying to
store a double Path header in the location table. It seems that
current size is:
lib/srdb1/schema/location.xml:
<column>
<name>path</name>
<type>string</type>
<size>&uri_len;</size>
<null/>
<default><null/></default>
<description>Path Header(s) per RFC 3327</description>
</column>
It seems to become 128 which is not enough at all for two Path headers
if the URI's contain parameters.
Is it ok if I increase it to 512? any other file to touch?
Hello Iñaki,
512 sounds a bit too large to me, this size is not used in any other fields in
the database definitions. What about setting it to 255? Replacing the uri_len
part with
<size>&hf_len;</size>
should do the trick. Then just run make dbschema, and commit also the updated
database definitions.
Regards,
Henning Westerholt
3 p.m.
Hello,
On 9/5/12 1:56 PM, Henning Westerholt wrote:
Am Mittwoch, 5. September 2012, 13:40:18 schrieb Iñaki
Baz Castillo:
dialog module uses 512 for each route set (caller/callee side), so
perhaps it should be used here the same, eventually defining a variable
for it and use it everywhere is stored a path/route set.
Besides regeneration of db creation scripts (with make dbschema), a
safety check has to be done to registrar/usrloc module to be sure it
does not use some static buffer of a lower size for handling the path.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat
Hi, I've experimented column size isues (too
small) when trying to
store a double Path header in the location table. It seems that
current size is:
lib/srdb1/schema/location.xml:
<column>
<name>path</name>
<type>string</type>
<size>&uri_len;</size>
<null/>
<default><null/></default>
<description>Path Header(s) per RFC 3327</description>
</column>
It seems to become 128 which is not enough at all for two Path headers
if the URI's contain parameters.
Is it ok if I increase it to 512? any other file to touch?
Hello Iñaki,
512 sounds a bit too large to me, this size is not used in any other fields in
the database definitions. What about setting it to 255? Replacing the uri_len
part with
<size>&hf_len;</size>
should do the trick. Then just run make dbschema, and commit also the updated
database definitions.
3:45 p.m.
New subject: Increase the size for the 'path' column in 'location' table
2012/9/5 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
dialog module uses 512 for each route set
(caller/callee side), so perhaps
it should be used here the same, eventually defining a variable for it and
use it everywhere is stored a path/route set.
Besides regeneration of db creation scripts (with make dbschema), a safety
check has to be done to registrar/usrloc module to be sure it does not use
some static buffer of a lower size for handling the path.
Thanks to all. Is it ok if I set the path size to 512 in master branch for now?
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
7 Sep
7 Sep
1:47 p.m.
New subject: Increase the size for the 'path' column in 'location' table
Am Mittwoch, 5. September 2012, 14:00:58 schrieb Daniel-Constantin Mierla:
Hello Daniel,
I've added the 512 size definition as "long_hf_len" to the schema defs and
changed the dialog xml files. If Inaki wants to do his change he could also use
this.
Cheers,
Henning
> Hi,
I've experimented column size isues (too small) when trying to
> store a double Path header in the location table. It seems that
> current size is:
[...]
512 sounds a bit too large to me, this size is
not used in any other
fields in the database definitions. What about setting it to 255?
Replacing the uri_len part with
<size>&hf_len;</size>
should do the trick. Then just run make dbschema, and commit also the
updated database definitions.
dialog module uses 512 for each route set (caller/callee side), so
perhaps it should be used here the same, eventually defining a variable
for it and use it everywhere is stored a path/route set.
Besides regeneration of db creation scripts (with make dbschema), a
safety check has to be done to registrar/usrloc module to be sure it
does not use some static buffer of a lower size for handling the path.
1:55 p.m.
New subject: Increase the size for the 'path' column in 'location' table
2012/9/7 Henning Westerholt <henning.westerholt(a)1und1.de>de>:
Hello Daniel,
I've added the 512 size definition as "long_hf_len" to the schema defs and
changed the dialog xml files. If Inaki wants to do his change he could also use
this.
Thanks Henning, I've commited the change into master branch.
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
4463
days inactive
4465
days old
6 comments
5 participants
participants (5)
-
Daniel-Constantin Mierla -
Henning Westerholt -
Henning Westerholt -
Iñaki Baz Castillo -
Juha Heinanen