<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3588
-- Commit Summary --
* core: Fixing transport=wss parsin * ut: Adding PROTO_WSS protocol to get_proto
-- File Changes --
M src/core/parser/parse_uri.c (39) M src/modules/tm/ut.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3588.patch https://github.com/kamailio/kamailio/pull/3588.diff
@joelbax pushed 1 commit.
e2424362c4dfc97b9922c13bfac65ccc00ecbf09 core: Style fixes
@joelbax pushed 1 commit.
c8a5265b0f159be472708e266fce46317dfffda4 core: Style formatting
The rfc7118 (https://www.rfc-editor.org/rfc/rfc7118.html) defines only `transport=ws`, where have you met `transport=wss`?
@miconda SIP.js is including it in the contact header, then, the register module keeps it. I think this is also happening with pjsip but I haven't had a chance to properly verify it. Also, IMHO, I think that this is still a misleading subject because, referring to Iñaki's message in jssip: https://groups.google.com/g/jssip/c/tWhZla-3Ktk, he says that it's like RFC3261 not defining `transport=tls` (that is actually defined in RTC5630) but we use it. Maybe time to do a RTC5630 equivalent for 7118 and define some uses for wss transport? :)
@joelbax: I think RFC3261 mention the deprecation of `transport=tls` for `sips` scheme (ie., end to end secure transmission), but it is defined in the grammar (e.g., for hop-by-hop tls usage). See RFC3261 page 223:
``` transport-param = "transport=" ( "udp" / "tcp" / "sctp" / "tls" / other-transport)
```
- https://datatracker.ietf.org/doc/html/rfc3261
@miconda our bad, SIP.js was configured to use transport=wss. Closing this PR.
I'm sorry for the inconvenience.
Closed #3588.
OK, though somehow I agree that not having wss in the transport is confusing, because it is in Via, but I wanted to be sure I haven't missed any new specs introducing it.
-
Daniel-Constantin Mierla -
joelbax