<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Support for concatenated SMS messages in smsops module.
The current implementation doesn't handle correctly concatenated SMSes. The patch adds support for them in the smsops module, including dumping a concatenated message to the log and new PVs with SMS message parameters.
There are also small fixes in the indentation - spaces are replaces with tabs, as this seeems to be the preferred approach in the file. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1617
-- Commit Summary --
* smsops: Add support for concatenated SMS in decode_3gpp_sms()
-- File Changes --
M src/modules/smsops/smsops_impl.c (472)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1617.patch https://github.com/kamailio/kamailio/pull/1617.diff
Merged #1617 into master.
Thanks!
Hi @tdimitrov @ngvoice Do you have any updated example script files (.cfg) and perhaps a sql table definition? I have several errors with the current example script file. Even if fixing the small errors, I am unsure if it will work out of the box for concatenated SMS?
Best Regards Lars
Hi @lasseo Sorry, but I haven't got a working SMSC routing script. I used dummy data only to fix the code.
Tsvetomir