#### Description <!-- Describe your changes in detail --> Changed char* by str in RPC function params to avoid memory problems You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1787
-- Commit Summary --
* secfilter: changed char* by str in RPC function params to avoid memory problems
-- File Changes --
M src/modules/secfilter/secfilter_rpc.c (52)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1787.patch https://github.com/kamailio/kamailio/pull/1787.diff
Just a side note for the future: passing structure variables as function parameters is not optimized if the structure is large (some compilers and static analyzers will complain). `str` is a small structure and it is fine, so not something that must to change here. Otherwise is recommended to pass the address (the pointer). What I mean is to have:
``` static int get_type(str *ctype) ```
instead of:
``` static int get_type(str ctype) ```
Merged #1787 into master.
-
Daniel-Constantin Mierla -
Jose Luis Verdeguer