Module: sip-router Branch: 4.1 Commit: a9b6cf96644589b462f02d009df768fece7e5c03 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a9b6cf96...
Author: Juha Heinanen jh@tutpro.com Committer: Juha Heinanen jh@tutpro.com Date: Sat Apr 5 11:28:34 2014 +0300
modules/sdpops: added sdp_with_transport_like() function
---
modules/sdpops/README | 107 +++++++++++++++++++++-------------- modules/sdpops/doc/sdpops_admin.xml | 25 ++++++++ modules/sdpops/sdpops_mod.c | 77 +++++++++++++++++++++++-- 3 files changed, 161 insertions(+), 48 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=a9b6...
Hello,
is this a new feature? why are you pushing this on 4.1? am I missing something here?
2014-04-05 10:29 GMT+02:00 Juha Heinanen jh@tutpro.com:
Module: sip-router Branch: 4.1 Commit: a9b6cf96644589b462f02d009df768fece7e5c03 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a9b6cf96...
Author: Juha Heinanen jh@tutpro.com Committer: Juha Heinanen jh@tutpro.com Date: Sat Apr 5 11:28:34 2014 +0300
modules/sdpops: added sdp_with_transport_like() function
modules/sdpops/README | 107 +++++++++++++++++++++-------------- modules/sdpops/doc/sdpops_admin.xml | 25 ++++++++ modules/sdpops/sdpops_mod.c | 77 +++++++++++++++++++++++-- 3 files changed, 161 insertions(+), 48 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=a9b6...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
modules/sdpops: added sdp_with_transport_like() function
while doing it, i noticed that several modules use memmem or ser_memmem function. memmem is built in, but requires
#define _GNU_SOURCE
it is used by auth_identity module. nathelper, rtpengine, and rttproxy modules (and now also sdpops) as well as parser use ser_memmem and each defines it separately.
what is the preferred way to straighten out this mess? can we assume that kamailio code is non-portable and thus defining _GNU_SOURCE is acceptable. if not, what is the best place to put ser_memmem so that it is defined only once?
-- juha
i didn't get any reply to this. does anyone have any opinion on the two issues raised or is it so that nobody cares about portability and if many modules and core re-define the same function?
-- juha
while doing it, i noticed that several modules use memmem or ser_memmem function. memmem is built in, but requires
#define _GNU_SOURCE
it is used by auth_identity module. nathelper, rtpengine, and rttproxy modules (and now also sdpops) as well as parser use ser_memmem and each defines it separately.
what is the preferred way to straighten out this mess? can we assume that kamailio code is non-portable and thus defining _GNU_SOURCE is acceptable. if not, what is the best place to put ser_memmem so that it is defined only once?
-- juha
On 08/04/14 21:39, Juha Heinanen wrote:
i didn't get any reply to this.
Perhaps would be more visible with a new subject -- your emails don't add Re: to subject of replied emails and they look like commit subjects.
does anyone have any opinion on the two issues raised or is it so that nobody cares about portability and if many modules and core re-define the same function?
It should be in one place and would be good to get rid of _GNU_SOURCE for this case. A good place will be ut.{h,c} in the core.
Cheers, Daniel
-- juha
while doing it, i noticed that several modules use memmem or ser_memmem function. memmem is built in, but requires
#define _GNU_SOURCE
it is used by auth_identity module. nathelper, rtpengine, and rttproxy modules (and now also sdpops) as well as parser use ser_memmem and each defines it separately.
what is the preferred way to straighten out this mess? can we assume that kamailio code is non-portable and thus defining _GNU_SOURCE is acceptable. if not, what is the best place to put ser_memmem so that it is defined only once?
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Daniel-Constantin Mierla -
Juha Heinanen -
Victor Seva