You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/664
-- Commit Summary --
* dispatcher: added ds_reload
-- File Changes --
M modules/dispatcher/dispatcher.c (17) M modules/dispatcher/doc/dispatcher.xml (7) M modules/dispatcher/doc/dispatcher_admin.xml (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/664.patch https://github.com/kamailio/kamailio/pull/664.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664
@@ -1350,6 +1350,20 @@ onreply_route {
</programlisting> </example> </section> + <section id="dispatcher.f.reload">
dispatcher.f.ds_reload is correct
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664/files/7cf474fdac56db2fcba80a45...
@@ -1350,6 +1350,20 @@ onreply_route {
</programlisting> </example> </section> + <section id="dispatcher.f.reload"> + <title> + <function moreinfo="none">ds_reload()</function> + </title> + <para> + Reloads the groups and included destinations. The command is + disabled for call load based dispatching (algorithm 10) since
The code doesn't indicate that it really is disabled in this situation. Do you mean "disabled" or "should not be used".
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664/files/7cf474fdac56db2fcba80a45...
You can already run rpc commands from the script. What does this patch add?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224891447
Thanks for the input. How would you run the RPC commands from the script?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224892097
@@ -1350,6 +1350,20 @@ onreply_route {
</programlisting> </example> </section> + <section id="dispatcher.f.reload"> + <title> + <function moreinfo="none">ds_reload()</function> + </title> + <para> + Reloads the groups and included destinations. The command is + disabled for call load based dispatching (algorithm 10) since
This is based on [this](https://github.com/kamailio/kamailio/blob/master/modules/dispatcher/dispatch...) and [this](https://github.com/kamailio/kamailio/blob/master/modules/dispatcher/doc/disp...). I copied the possible problems description using a similar function.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664/files/7cf474fdac56db2fcba80a45...
There is support in the jsonrpc-s module. Kind of hidden, but still there :-)
http://kamailio.org/docs/modules/4.4.x/modules/jsonrpc-s.html#jsonrpc-s.f.js...
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224896816
Didn't see that one coming! ;-)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224897816
It's ok to export this function directly, can be handy sometimes to use it directly, without rpc workaround.
But the description needs to be amended, because the reload is not disabled anymore for algorthm 10 (it was some time ago).
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224898805
Even though I see you're solution as a valid solution, I still see this exported function as valuable. Using RPC to trigger an internal mechanism can overload this procedure.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224899232
@miconda I'll change the description.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224899361
I agree that it is useful as a simplification, but wanted to know if there was some additional benefits. You may want to add counters on how many dispatcher targets and groups that was loaded or something like that while you are at it - or a checksum check so I can check if the list was actually changed. Just some ideas to make this function an improvement :-)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-224905221
@miconda I'll just leave this _PR_ as it is, please let me know if you want to integrate this change and if you'll merge the changes and close the _PR_ or you want me to do it. Thanks!
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#issuecomment-225148877
Merged #664.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/664#event-691785758
-
Daniel-Constantin Mierla -
Luis Martin Gil
-
Olle E. Johansson