<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> * All functions are exported to kemi You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3945
-- Commit Summary --
* secfilter is fully KEMIized * secfilter: fix the failed format check
-- File Changes --
M src/modules/secfilter/secfilter.c (88)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3945.patch https://github.com/kamailio/kamailio/pull/3945.diff
The last time the format-check failed but I did the clang-format command with your configurations
@bazrafshanmh pushed 1 commit.
01f7750a0003b0ac6153efe9cf3689495c8c7e6a secfilter: do some changes to pass format check
Yes, the clang format check is still failing. Just to double check, you've run clang-format on your code?
I ran the clang-format multiple times. but to make the code prettier and more similar to the official codes I edited them manually and made them more like other codes. this pull request will be closed
Closed #3945.
Especially for KEMI definitions there is a flag to tell the clang-format to ignore the format to format it pretty. Look e.g. to src/modules/evapi/evapi_mod.c, static sr_kemi_t sr_kemi_evapi_exports[].
-
bazrafshan.m.h -
Henning Westerholt