I'm building in Docker containers, and with the minimal CentOS/Fedora/whatever image you get from official repos, builds will fail without installing these.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2368
-- Commit Summary --
* Add some missing build requirements
-- File Changes --
M pkg/kamailio/obs/kamailio.spec (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2368.patch https://github.com/kamailio/kamailio/pull/2368.diff
Not having the commit first line as per contributing guide, I added those build requirements as part of commit 71248a2f7394b69c85f030f103afb2a8f6a5a49e, along with other changes.
If any issue introduced (eg., I added also pkgconfig which makes it easier to detect path to libs and include files), open an issue, or make a PR, but follow the contributing guidelines so the PR can be merged from here using the web ui:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Closed #2368.
Hi Daniel Think this change ``` %if 0%{?rhel} || 0%{?centos_ver} %if 0%{?rhel} > 6 || 0%{?centos_ver} > 6 BuildRequires: pkgconfig %endif %else BuildRequires: pkgconfig %endif ``` Is equal to ``` %if 0%{?rhel} %if 0%{?rhel} > 6 BuildRequires: pkgconfig %endif %else BuildRequires: pkgconfig %endif ``` And equal to ``` %if 0%{?rhel} > 6 BuildRequires: pkgconfig %else BuildRequires: pkgconfig %endif ``` As `pkgconfig` is present in all RPM supported dists think we can use ``` BuildRequires: pkgconfig ```
What you think?
Not having CentOS/RHEL 6 around, I googled a bit and couldn't find it for sure that they ship with pkgconfig. If yes, go ahead and remove that condition and add pkgconfig to the BuildRequires listing make, gcc, etc... Thanks!
yes, exists ```sh [safarov@safarov-dell kamailio-upstream]$ docker run -it centos:6 [root@c8b81ef4309e /]# pkg-config --version 0.23 ``` I make changes
-
Daniel-Constantin Mierla -
Oded Arbel
-
sergey-safarov