…g.briefing
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description IN some scenarios I found useful to have the timestamps (init, start, end) of the dialog as output of the dlg.briefing command. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2279
-- Commit Summary --
* dialog: add dialog init, start end end timestamps to the output of dlg.briefing
-- File Changes --
M src/modules/dialog/dialog.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2279.patch https://github.com/kamailio/kamailio/pull/2279.diff
Thanks! It can be merged.
However, for better flexibility, I was thinking to add an option parameter to this command to specify the fields to be returned in a string-of-char-flags manner. Have hash label, hash id and call-id always int attributes of the output, the the rest be specified in the parameter, like:
* `f` - from uri * `F` - from tag * `t` - to uri * `T` - to tag * ...
Then use `kamcli rpc dialog.briefing "fFtT..."` -- the order of char-flags won't matter. When the parameter is not provided, a default value can be used for it (like what is printed now, before or after this PR).
Nice idea, if I have time the next days I can start looking at it.
Merged #2279 into master.