Fixes out-of-sequence version when subs_db_mode <> 3 and fast_notify is enabled.
Version is incremented only when copy is updated in memory. Therefore, currently:
On SUBSCRIBE, subscription is updated first, so NOTIFY body contains newly incremented version.
But on PUBLISH, aux_body_processing is called first, so NOTIFY body contains previously stored version. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/917
-- Commit Summary --
* presence: delay aux_body_processing until after subscription has been updated
-- File Changes --
M src/modules/presence/notify.c (42) M src/modules/presence/notify.h (2) M src/modules/presence/presence.c (2) M src/modules/presence/subscribe.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/917.patch https://github.com/kamailio/kamailio/pull/917.diff
Thanks -- it can be merged if nobody else has something against.
Merged #917.
Thanks - can it be backported also?
Charles
On 9 January 2017 at 10:41, Charles Chance notifications@github.com wrote:
Merged #917 https://github.com/kamailio/kamailio/pull/917.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/917#event-915742731, or mute the thread https://github.com/notifications/unsubscribe-auth/AF36ZQObSz41XCs7ZaS7mOM2AP70WVIiks5rQg7PgaJpZM4LdPm5 .
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
@miconda - is it OK to backport to 4.4?
If nobody finds an issue with it, for me it's fine to backport.
Ok, I will wait another couple of weeks. We have it already in production since last week, so if no other issue reported by end of January I will assume it is safe to backport.
Hello again - given today's announcement of upcoming 4.4.5 release in the next couple of days, I would ask anyone with any issues to report it here, otherwise, I will backport tomorrow evening to ensure it is included in the release.