Hello,
do not forget that you have to split the commits per component (e.g.,
core, module, ...):
-
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#co…
It makes it easier to review by the maintainer of each component as well
as for management in case of need to revert, backport, etc ...
When I have to deal with same commit that has to be done for many
modules, I use a shell script that I edit to change the commit messages
and then run in the root folder with Kamailio sources:
"""
MODS=`git status | grep "modified:" | grep "src/modules/" | awk '{
print
$2 }' | awk -F/ '{ print $1 "/" $2 "/" $3 }' | uniq`
for M in $MODS
do
NAME=`echo $M | awk -F/ '{ print $3 }'`
echo "module path: $M"
echo "module name: $NAME"
git ci -n ${M}/ -m "${NAME}: use literal module name for stats
group" -m "- prevent conflicts with global exports"
done
"""
For core I do it separately, it is usually a single commit.
Also, backporting has to be done using "git cherry-pick -x ...", like at:
-
https://www.kamailio.org/wikidocs/devel/backporting-to-3.2.x/#backporting-t…
This helps to track easier what commits were not backported.
Cheers,
Daniel
On 26.02.24 03:41, S-P Chan via sr-dev wrote:
Module: kamailio
Branch: master
Commit: 8b2573c1f7c5e4bed24f8c5ca09817f613641a03
URL:
https://github.com/kamailio/kamailio/commit/8b2573c1f7c5e4bed24f8c5ca09817f…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2024-02-26T10:40:19+08:00
OpenSSL integration: manage curl_global_init(...) used by modules
- http_client, http_async_client, xcap_client use libcurl
- call curl_global_init in a thread executor as it invokes
OpenSSL functions on Debian 12
- clang-format
---
Modified: src/core/rthreads.h
Modified: src/modules/http_async_client/http_multi.c
Modified: src/modules/http_client/http_client.c
Modified: src/modules/xcap_client/xcap_client.c
---
Diff:
https://github.com/kamailio/kamailio/commit/8b2573c1f7c5e4bed24f8c5ca09817f…
Patch:
https://github.com/kamailio/kamailio/commit/8b2573c1f7c5e4bed24f8c5ca09817f…
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-leave(a)lists.kamailio.org
--
Daniel-Constantin Mierla (@
asipto.com)
twitter.com/miconda --
linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services --
asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin --
kamailioworld.com