29 Mar
2023
29 Mar
'23
9:36 a.m.
As discussed on the mailinglist [1] the `id` field of the location database in the
`userloc` module has the data type `INT(10)`. This can be too small for large long running
installations of kamailio. This changes the data type of the `id` field from `INT(10)` to
`BIGINT`
[1]:
https://lists.kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kamailio.o…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3407
-- Commit Summary --
* userloc: change data type of id field to BIGINT
-- File Changes --
M src/modules/p_usrloc/location.sql (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3407.patch
https://github.com/kamailio/kamailio/pull/3407.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3407
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3407(a)github.com>
29 Mar
29 Mar
9:44 a.m.
The database structure should be defines via xml file in `src/lib/srdb1/schema/`, but I
guess that is not done for p_usrloc.
While I am not the maintainer of the p_usrloc module, so I won't going to make the
decision for it, maybe it would be good to have an uniform approach for all tables.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3407#issuecomment-1488029751
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3407/c1488029751(a)github.com>
10:04 a.m.
@miconda You are right, the p_usrloc DB scheme should be also moved to the
src/lib/srdb/schema (similar to others IMS modules). It already got out of sync with the
main usrloc module, some colums were not increased in the last years.
The p_usrloc is a special module, and most of its users are using their own scheme anyway.
So I do not see a big value of adapting the ID column in this scheme.
As mentioned already in the list discussion, the id column is not used from Kamailio, so
you can just adapt it as you wish. My recommendation would be to to close this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3407#issuecomment-1488051262
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3407/c1488051262(a)github.com>
30 Mar
30 Mar
11:10 p.m.
Close this one - I will make a dedicated commit moving the p_usrloc.sql to the XML schema
directory.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3407#issuecomment-1490885121
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3407/c1490885121(a)github.com>
11:10 p.m.
Closed #3407.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3407#event-8891454447
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3407/issue_event/8891454447(a)github.com>
606
days inactive
607
days old
4 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Julius Flohr