Patches item #3035778, was opened at 2010-07-28 10:04
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=303577…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.5.x
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Alex Hermann (axlh)
Assigned to: Daniel-Constantin Mierla (miconda)
Summary: Fix registrar when fetching binding for unregistered user
Initial Comment:
When an UA fetches the bindings for a user and the user isn't registered, properly
return an empty contact.
----------------------------------------------------------------------
Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-07-30 20:48
Message:
Patch committed on git master branch and svn 1.5. Thanks!
----------------------------------------------------------------------
Comment By: Iñaki Baz Castillo (ibc_sf)
Date: 2010-07-30 12:31
Message:
Reopened as it's clear now the purpose of this patch.
----------------------------------------------------------------------
Comment By: Alex Hermann (axlh)
Date: 2010-07-30 11:59
Message:
Sorry, the patch is already a bit old and i got the description wrong.
The patch is actually an addendum to bug 2851214. It makes sure kamailio
doesn't return someone else's contact in case there is a failure. The
contacts are stored in a global variable and needs to be cleared if it
isn't filled with valid contacts.
Please reopen.
----------------------------------------------------------------------
Comment By: Iñaki Baz Castillo (ibc_sf)
Date: 2010-07-28 13:29
Message:
A "Contact" header with no value is *not* valid according to SIP BNF
grammar so in case a UA fetches its bindging and there are not bindings
then the registrar should reply a 200 without "Contact" header. Taking this
into account I suspect that this patch is wrong.
As a side note, there is a bug/issue open for RFC 3261 related to this
topic as the RFC 3261 seems to state that the registrar should reply a
200 with a Contact header containing all the bindings. But it's clear
(also in the RFC bug report) that the BNF grammar cannot be violated
so there should be NO Contact header if there are no bindings.
I close this bug as it not valid. However as Daniel said please use
http://sip-router.org/tracker/ for future reports :)
----------------------------------------------------------------------
Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-07-28 10:07
Message:
Can you use the tracker at sip-router.org?
http://sip-router.org/tracker/
SF tracker should not be used anymore for new items.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=303577…