Module: sip-router Branch: master Commit: 6a09b5abafe2b67e7f7959221d4486fab59c24a2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6a09b5ab...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Wed Feb 16 10:53:31 2011 +0100
core: log message for no 2nd via in reply sent to L_DBG
---
forward.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/forward.c b/forward.c index 175f54b..f073f7c 100644 --- a/forward.c +++ b/forward.c @@ -783,7 +783,7 @@ int forward_reply(struct sip_msg* msg) || (msg->via2==0) || (msg->via2->error!=PARSE_OK)) { /* no second via => error */ - LOG(L_INFO, "broken reply to forward - no 2nd via\n"); + LOG(L_DBG, "broken reply to forward - no 2nd via\n"); goto error; }
On Wednesday 16 February 2011 10:55:00 Daniel-Constantin Mierla wrote:
Commit: 6a09b5abafe2b67e7f7959221d4486fab59c24a2
core: log message for no 2nd via in reply sent to L_DBG
May i ask why you change this? I (and the support dept.), would like to know that a reply is not being forwarded without enabling gazillions of debug log lines. I think error conditions should be visible without enabling debug logging.
On 2/17/11 9:42 AM, Alex Hermann wrote:
On Wednesday 16 February 2011 10:55:00 Daniel-Constantin Mierla wrote:
Commit: 6a09b5abafe2b67e7f7959221d4486fab59c24a2 core: log message for no 2nd via in reply sent to L_DBG
May i ask why you change this? I (and the support dept.), would like to know that a reply is not being forwarded without enabling gazillions of debug log lines. I think error conditions should be visible without enabling debug logging.
This is because all the nat options pings end up here and a lot of messages are then in the log.
Probably you can add a check of second via in onreply_route and print a log message as you like. Should be even better as you can print more details. The log message from the code was very dry, not telling anything more, so if would be a case to troubleshoot didn't help that much.
Cheers, Daniel
-
Alex Hermann -
Daniel-Constantin Mierla