<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> This PR introduces a new mode on the modparam `evlreq_mode` to allow for choosing what should emit the local-request event. It enables the ACK that are generated from kamailio to also emit the event if the user chose to do so.
With this PR the modes are - 0 for None - 1 for Cancel - 2 for Acks - 3 for Both
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4343
-- Commit Summary --
* tm: Trigger local-request event for ACK on negative replies * update for kemi * tm: add validation for the evlreq_mode param
-- File Changes --
M src/modules/tm/config.h (10) M src/modules/tm/t_reply.c (60) M src/modules/tm/tm.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4343.patch https://github.com/kamailio/kamailio/pull/4343.diff
henningw left a comment (kamailio/kamailio#4343)
Thanks for the PR - can you fix the one wrong commit message?
@xkaraman pushed 3 commits.
bcfaff4aa6cfc591686dcf39af17c6522bad951b tm: Trigger local-request event for ACK on negative replies 3e9e5a3ebbe5cd3d151b99f80e496966d73e0bd4 tm: update for kemi 0801cdabdbc02f54dd79c8b818980c79c335ff1b tm: add validation for the evlreq_mode param
xkaraman left a comment (kamailio/kamailio#4343)
Fixed, it can also me be merged with the first commit after some review and testing, if need.