<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description To prevent code duplication I refactored ds_log_set a bit to allow for re-use of loop over all destinations and execute a callback. Perhaps there are more places this could be useful.
Add dispatcher.add rpc call to add destinations to in-memory dispatcher list. This allows for more quick and flexible updates to dispatcher list in kamailio.
_A few ideas that build on top of this change are:_
1. modparam for reload to keep in-memory entries or not 2. modparam to not read list or db 3. `dispatcher.remove _group_ _destination_` 4. modifying in routing script with `ds_add_dst`/`ds_remove_dst`
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1782
-- Commit Summary --
* dispatcher: add destination to in-memory dispatcher list
-- File Changes --
M src/modules/dispatcher/dispatch.c (81) M src/modules/dispatcher/dispatch.h (1) M src/modules/dispatcher/dispatcher.c (29) M src/modules/dispatcher/doc/dispatcher_admin.xml (32)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1782.patch https://github.com/kamailio/kamailio/pull/1782.diff
Some delay from here, being busier that usual with stuff related to Kamailio World organization, in preparation to open the registration ...
I looked a bit and just to be sure I got the concept right, this operation involves: * clone the existing groups and destinations in a new structure * add the new destination in the new structure * switch to use the new structure for routing
Is it right?
With the current design, this should be a good approach. I am merging it, thanks!
Merged #1782 into master.