Added corrections for 200OK reply on Re-Registration according to RFC3261 - registrar respond with multiple bindings in case of multiple bindings. Added a new parameter skip_multiple_bindings_on_reg_resp for 200OK reply used for Re-Registration. Default value is 0. If set to 1 - registrar replies only with current contact, not with multiple bindings.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3146
-- Commit Summary --
* ims_registrar_scscf: 200OK changes according to RFC3261
-- File Changes --
M src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml (20) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2) M src/modules/ims_registrar_scscf/save.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3146.patch https://github.com/kamailio/kamailio/pull/3146.diff
@alexyosifov: thanks for this PR! Given that you are quite active with the IMS extensions and we lack contributors there, I am going to grant access to the repository so you can push commits directly, or accept and merge PRs on those components.
You can still do PRs to these modules if you want other developers to comment on the changes. Changing code to other modules or components should still be done with PR to allow the developers to review and avoid conflicts of working on the same code part at that moment.
@alexyosifov: invitation for developers team sent, once you accept it, you should be able to merge this PR, which you can do at your convenience.
@miconda Thank you for your trust! It will be merged in 2-3 days if there are no other comments.
Merged #3146 into master.
@alexyosifov please, before merge, rebase so we can avoid the merge in git history
``Merge pull request #3146 from alexyosifov/skip_multiple_bindings_on_reg_resp``
-
alexyosifov -
Daniel-Constantin Mierla
-
Victor Seva