I noticed that accounting to database has stopped working. I don't know when it has happened, but at least I have the problem with master. My acc config is like this:
modparam("acc", "db_url", "mysql://user:pass@127.0.0.1/sip_proxy_usage") modparam("acc", "db_flag", 7) modparam("acc", "failed_transaction_flag", 8) modparam("acc", "failed_filter", "407") modparam("acc", "db_table_acc", "accounting") modparam("acc", "acc_sip_code_column", "response_code") modparam("acc", "acc_sip_reason_column", "response_reason") modparam("acc", "db_insert_mode", 2) modparam("acc", "reason_from_hf", 1)
If I change db_flag to log_flag, accounting to syslog works fine. With db_flag, nothing is inserted to db and no error are produced to syslog or mysql error.log.
Has something changed in acc db config that I have not noticed?
-- Juha
Found the reason why db acc had stopped working: I had removed async_workers parameter. Looks like acc module does not insert anything if db_insert_mode=2 and there is no async workers. From README, I get the impression that it should be doing standard insert in that case:
6.28. db_insert_mode (integer)
If set to 2, async insert is used if the db driver module has support for it and if async_workers core parameter value is greater than 0. If not, then standard INSERT is used.
-- Juha
Indeed, the docs are misleading. The test is on advertised async insert in db driver and if yes, it is used. If async workers is not set, then nothing happens in this case (I added a warning in the code for this case).
Sync insert is done if async insert is wanted but not available in the db driver and this is done in the acc module.
This needs to be fixed to match the docs, but I am not sure where it would a better place, inside acc (test if async workers is not set and do db sync insert, so a solution specific for acc) or do it inside db mysql async insert function (a global behaviour across modules when db mysql is used) ... any preference by people here?
Cheers, Daniel
On 08.11.17 12:19, Juha Heinanen wrote:
Found the reason why db acc had stopped working: I had removed async_workers parameter. Looks like acc module does not insert anything if db_insert_mode=2 and there is no async workers. From README, I get the impression that it should be doing standard insert in that case:
6.28. db_insert_mode (integer)
If set to 2, async insert is used if the db driver module has support for it and if async_workers core parameter value is greater than 0. If not, then standard INSERT is used.
-- Juha
Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Daniel-Constantin Mierla writes:
This needs to be fixed to match the docs, but I am not sure where it would a better place, inside acc (test if async workers is not set and do db sync insert, so a solution specific for acc) or do it inside db mysql async insert function (a global behaviour across modules when db mysql is used) ... any preference by people here?
If async workers have not been configured for a module feature that would need them, then Kamailio should fail to start and produce an error message,
-- Juha
On 10.11.17 07:46, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
This needs to be fixed to match the docs, but I am not sure where it would a better place, inside acc (test if async workers is not set and do db sync insert, so a solution specific for acc) or do it inside db mysql async insert function (a global behaviour across modules when db mysql is used) ... any preference by people here?
If async workers have not been configured for a module feature that would need them, then Kamailio should fail to start and produce an error message,
well, in this case is a bug, because it was supposed to work with or without async workers, as per docs. The question was where to do the sync insert when async workers are not set: do a fix only for acc module because it is the one supposed to act like written in its docs; or do it inside the db_mysql module so if any other module in the future that tries to do async insert without async workers will get a sync insert.
When I did this feature I inspired from the mysql delayed insert, which, if I didn't get it wrong, just does the normal insert when the db engine has no support for delayed....
Cheers, Daniel
-
Daniel-Constantin Mierla -
Juha Heinanen