git:bpintea/asi_binrpc2: top level define for SERLIBPATH so that it doesn' t have to be defined in every
15 Jan
2010
15 Jan
'10
12:21 a.m.
Module: sip-router
Branch: bpintea/asi_binrpc2
Commit: c5dcf62a1d51962713f61e29e0027bb1f95cb2bc
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5dcf62…
Author: bpi <bpi(a)machine.office.iptego.net>
Committer: bpi <bpi(a)machine.office.iptego.net>
Date: Thu Jan 14 22:31:30 2010 +0100
top level define for SERLIBPATH so that it doesn't have to be defined in every
module using a lib
---
Makefile.modules | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.modules b/Makefile.modules
index f1f172b..7d222f8 100644
--- a/Makefile.modules
+++ b/Makefile.modules
@@ -58,6 +58,7 @@ MOD_NAME=$(NAME:.so=)
# allow placing modules in separate directory apart from ser core
COREPATH ?=../..
+SERLIBPATH ?= $(COREPATH)/lib
ALLDEP=Makefile $(COREPATH)/Makefile.sources $(COREPATH)/Makefile.rules \
$(COREPATH)/Makefile.modules $(COREPATH)/Makefile.dirs $(COREPATH)/config.mak
15 Jan
15 Jan
3:46 p.m.
New subject: git:bpintea/asi_binrpc2: top level define for SERLIBPATH so that it doesn' t have to be defined in every
On Thursday 14 January 2010, Bogdan Pintea wrote:
top level define for SERLIBPATH so that it doesn't
have to be defined in
every module using a lib
Hi Bogdan,
did i understand you correctly, does this means that we could remove the
redundant declarations from the modules Makefiles after you merged this into
master?
Cheers,
Henning
4:12 p.m.
New subject: git:bpintea/asi_binrpc2: top level define for SERLIBPATH so that it doesn' t have to be defined in every
Hi Henning,
On 01/15/10 14:46, Henning Westerholt wrote:
did i understand you correctly, does this means that
we could remove the
redundant declarations from the modules Makefiles after you merged this into
master?
Yes, that was the intention.
On the same page of small annoying things, I would have the "-I../.."
included in the DEFS for the modules, in the modules' makefile, so the
#include "../../some_top_level.h" in modules' source can get a bit shorter.
Cheers,
Bogdan.
4:33 p.m.
New subject: git:bpintea/asi_binrpc2: top level define for SERLIBPATH so that it doesn' t have to be defined in every
On 1/15/10 3:12 PM, Bogdan Pintea wrote:
Hi Henning,
On 01/15/10 14:46, Henning Westerholt wrote:
that's not annoying, it is feature, lets me know where the heck that
file is located...
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
did i understand you correctly, does this means
that we could remove the
redundant declarations from the modules Makefiles after you merged this into
master?
Yes, that was the intention.
On the same page of small annoying things, I would have the "-I../.."
included in the DEFS for the modules, in the modules' makefile, so the
#include "../../some_top_level.h" in modules' source can get a bit
shorter.
5427
days inactive
5428
days old
3 comments
4 participants
participants (4)
-
Bogdan Pintea -
Bogdan Pintea -
Daniel-Constantin Mierla -
Henning Westerholt