[utils/db_berkeley/kambdb_recover.c:339] -> [utils/db_berkeley/kambdb_recover.c:341]: (warning) Either the condition '!tbc' is redundant or there is possible null pointer dereference: tbc. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1169
-- Commit Summary --
* resolve an issue found by cppcheck:
-- File Changes --
M utils/db_berkeley/kambdb_recover.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1169.patch https://github.com/kamailio/kamailio/pull/1169.diff
Please read https://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message
Please read https://github.com/blog/2111-issue-and-pull-request-templates
@chipitsine - if you have read the block post you pointed above, you would see the reference to .github/ subfolder, and CONTRIBUTING.md file is already there, with section for commit message:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
I will push the patch manually.
Closed #1169.
@miconda - yes, I noticed .github subfolder a bit later. I was somewhat surprized "why do they point me to contribution guide in such weird way", I was ok to see contribution guide during PR process (and I meant that exactly)
sorry for that.
thank you for pushing the patch anyway
The wiki page was there before github added the options for templates and many still refer to it being used to that.
I expected that github points to CONTRIBUTING.md when a pull request is created, as I don't do PRs, but commit directly, so I couldn't check myself.
Anyhow, I just pushed a pull request template to make it more visible.
Thanks for your contribution
-
Daniel-Constantin Mierla -
Ilya Shipitsin
-
Victor Seva