[kamailio/kamailio] branch 4.4: Added SPEC file for CentOS7 (#966)

List overview All Threads
Download

newer

older

git:4.4:239f3cfa:...

git:master:f1630caf: pv: add the...

sergey-safarov

4 Feb 2017 4 Feb '17

5:49 a.m.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/966

-- Commit Summary --

* branch 4.4: Added SPEC file for CentOS7

-- File Changes --

A pkg/kamailio/centos/7/kamailio.service (1) A pkg/kamailio/centos/7/kamailio.spec (1386) A pkg/kamailio/centos/7/kamailio.sysconfig (1) A pkg/kamailio/centos/7/kamailio.tmpfiles (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/966.patch https://github.com/kamailio/kamailio/pull/966.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966

Attachments:

attachment.html (text/html — 2.9 KB)

Show replies by date

Victor Seva

4 Feb 4 Feb

10:01 a.m.

New subject: [kamailio/kamailio] branch 4.4: Added SPEC file for CentOS7 (#966)

linuxmaniac requested changes on this pull request.

Please follow the commit message format described at https://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message

please add prefix 'pkg/kamailio/centos' to your descriptions

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-20145679

sergey-safarov

1:47 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: branch 4.4 - Added SPEC file for CentOS7 (#966)

@linuxmaniac thanks for fast review. Prefix added.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-277447013

Victor Seva

4:13 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: branch 4.4 - Added SPEC file for CentOS7 (#966)

please remove the branch 4.4 reference from the commit message

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-277455909

Victor Seva

6 Feb 6 Feb

8:30 a.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

linuxmaniac requested changes on this pull request.

please use kamailio.service added by @grumvalski at 1c9078cfef11c947149b8c46d8e6ba754d956d7d and do not create a link for kamailio.sysconfig, create the file.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-20213501

sergey-safarov

8:40 a.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

Hello @linuxmaniac Why not use kamailio.service and kamailio.sysconfig from debian? This is more easy to maintain packaging.

About difference of environment file location. This is adjusted in kamailio.spec:595

https://github.com/kamailio/kamailio/pull/966/files#diff-7757a46a5c00eaeca33...

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-277615812

lazedo

7 Feb 7 Feb

1:28 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

lazedo requested changes on this pull request.

...

+%package json +Summary: json string handling and RPC modules for Kamailio. +Group: System Environment/Daemons +Requires: json-c, libevent, kamailio = %ver +BuildRequires: json-c-devel, libevent-devel + +%description json +json string handling and RPC modules for Kamailio. + + +%if %{with kazoo} +%package kazoo +Summary: Kazoo middle layer connector support for Kamailio +Group: System Environment/Daemons +Requires: libuuid, kamailio = %ver

missing rabbitmq-c, json-c, libevent

...

+%package json

+Summary: json string handling and RPC modules for Kamailio. +Group: System Environment/Daemons +Requires: json-c, libevent, kamailio = %ver +BuildRequires: json-c-devel, libevent-devel + +%description json +json string handling and RPC modules for Kamailio. + + +%if %{with kazoo} +%package kazoo +Summary: Kazoo middle layer connector support for Kamailio +Group: System Environment/Daemons +Requires: libuuid, kamailio = %ver +BuildRequires: rabbitmq-c-devel, json-c-devel, libuuid-devel

missing libevent-devel

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-20505895

sergey-safarov

1:41 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

@sergey-safarov pushed 1 commit.

ea2b4df pkg/kamailio/centos: Updated kazoo module dependency

-- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/966/files/9fc592783b365b6c628290fc...

sergey-safarov

1:54 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

@lazedo I will update master branch after this PR is merged.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-278005998

lazedo

2:12 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

lazedo approved this pull request.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-20515854

Victor Seva

5:24 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

...

Why not use kamailio.service and kamailio.sysconfig from debian? This is more easy to maintain packaging.

because is what we have in master and from my point of view is better to be independient

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-278073170

sergey-safarov

9 Feb 9 Feb

12:25 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

Hello @linuxmaniac Pull request updated.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#issuecomment-278626980

Victor Seva

2:26 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

linuxmaniac approved this pull request.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#pullrequestreview-21019167

Victor Seva

2:27 p.m.

New subject: [kamailio/kamailio] pkg/kamailio/centos: Added SPEC file for CentOS7 (#966)

Merged #966.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/966#event-955652100

2940

Age (days ago)

2945

Last active (days ago)

sr-dev@lists.kamailio.org

13 comments

3 participants

tags (0)

participants (3)

lazedo
sergey-safarov
Victor Seva