[kamailio] Adding publish in registration functionality, sending "closed" NOTIFY when presense has expired (#177)
27 May
2015
27 May
'15
1:56 p.m.
The commit contains pua_usrloc modifications, which simplifies the publish and regisration
processes: in every REGISTER an implicit publish is built in. In this way, a device e.g.
do not need to send two individual request towards kamailio (REGISTER, PUBLISH), it can be
achieved in a single but extended REGISTER request.
Another small fix is that if the publication is expired (due to broken TCP e.g.), a
"closed" NOTIFY should be sent to the contacts.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/177
-- Commit Summary --
* Adding publish in registration functionality
-- File Changes --
M modules/pua_usrloc/pua_usrloc.c (4)
M modules/pua_usrloc/ul_publish.c (152)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/177.patch
https://github.com/kamailio/kamailio/pull/177.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177
1 Jun
1 Jun
11:12 a.m.
What do you mean by "a single but extended REGISTER request"? Can you give an
example of such REGISTER request?
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-107355252
11:27 a.m.
Normally, the REGISTER and PUBLISH are sent separately. In our solution, it is not needed,
we should send only a „single” REGISTER with some „publish info”. A custom SIP header
(PresenceInReg) is defined in REGISTER which contains the presence information. Here is an
example:
REGISTER sips:example.com:443 SIP/2.0
Via: SIP/2.0/TLS 192.168.1.100;branch=z9hG4bK-524287-1---ec449f7fc5b0af2a;rport
Max-Forwards: 70
PresenceInReg:
device;open;<status><state>online</state><message>normal</message></status>
Contact:
<sip:1111111111@192.168.1.100;transport=tls>;+sip.instance="785722228"
To: "Andrea Máté"<sips:11111111@sip01.crypttalk.com:443>
From: "Andrea Máté"<sips:11111111@sip01.crypttalk.com:443>;tag=f4a82829
Call-ID: fWmDgP_8wJvQAKTM_b4ajw..
CSeq: 27 REGISTER
Expires: 800
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, UPDATE, INFO, MESSAGE, REFER, NOTIFY, SUBSCRIBE,
REGISTER
Supported: norefersub, replaces, eventlist
User-Agent: Example_UA
Authorization: Digest
username="1975539839",realm="example.com",nonce="VWwOB1VsDNsw7TW7jHJhrpX40TfhJA7t",uri="sips:example.com:443",response="78ab5f7a36c8ddae6f69c5262e240d8b",algorithm=MD5
X-CT-PushInfo:
I;iNRvcCqBGqLeprCFaA7P+jrNwg2q+VYZ20FPw3Rv5hU=;hu;Ringing-Ringtone_long.wav,im.wav,ct_autoreject.wav
Content-Length: 0
Peter
From: Daniel-Constantin Mierla [mailto:notifications@github.com]
Sent: Monday, June 1, 2015 10:13 AM
To: kamailio/kamailio
Cc: Péter Barabás
Subject: Re: [kamailio] Adding publish in registration functionality, sending
"closed" NOTIFY when presense has expired (#177)
What do you mean by "a single but extended REGISTER request"? Can you give an
example of such REGISTER request?
—
Reply to this email directly or view it on
GitHub<https://github.com/kamailio/kamailio/pull/177#issuecomment-107355…52>.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-107360743
11:35 a.m.
So this is a custom extension of you, not a standard, right?
If yes, I suggest that you change the patch to export a new function with a new name where
the relevant values are given as parameter, without taking anything from the SIP request
inside the function, so it becomes generic of what the custom header name is and the
format of the header body.
Now you practically disable the rfc version with defines, so it is not going to work
anymore for that. The RFC requirements implementation must be always there.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-107363617
25 Jun
25 Jun
12:59 p.m.
Is there any interest in following up with this pull request? There was no message for a
while answering to my questions and suggestions.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-115195734
1:09 p.m.
I'll check the source soon in next days and will make the proposed changes in it.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-115197442
20 Nov
20 Nov
3 p.m.
Long time and no follow up. I am closing the pull request for now, because it replaces the
standard IETF RFC requirements with some custom approach. The item can be reopen if a
patch with suggestions made in comments above is provided.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#issuecomment-158392920
3 p.m.
Closed #177.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/177#event-470355712
3290
days inactive
3467
days old
7 comments
2 participants
participants (2)
-
barabasp -
Daniel-Constantin Mierla