Two fixes in this PR. The first is to perform the ntohs also on hep messaging carrying payload other than SIP. The scond is to take in count the definition of captid chunk in HEPv3 (uint32 BE) different from the one for HEPv2 (uint16 LE). You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/874
-- Commit Summary --
* sipcapture: perform ntohs on src and dst port when payload is not SIP * sipcapture: fix captid extraction from hep header for v3
-- File Changes --
M modules/sipcapture/hep.c (18) M modules/sipcapture/hep.h (6) M modules/sipcapture/sipcapture.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/874.patch https://github.com/kamailio/kamailio/pull/874.diff
Merged #874.
thank you!
Should I adapt the fixes for 4.4? Being a fix I'd say yes.
On Thu, Dec 1, 2016 at 1:55 PM, Alexandr Dubovikov <notifications@github.com
wrote:
Merged #874 https://github.com/kamailio/kamailio/pull/874.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/874#event-878409246, or mute the thread https://github.com/notifications/unsubscribe-auth/ADip49Enu7U-qpN8KXaqhGtas7awOY0Iks5rDsPDgaJpZM4LAeL5 .
@grumvalski yes, please do cherry pick :-)
thank you!
-
Alexandr Dubovikov -
Federico Cabiddu