<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
In our setup, we need one more ratelimit queue (in addition to the default of 10). In this pull request, I am increasing the default number of ratelimit queus to 16.
Please let me know if this pull request is ok, or if I should do it via a modparam and dynamic allocation of ```static rl_queue_t queues```. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2257
-- Commit Summary --
* ratelimit: increase default number of queues
-- File Changes --
M src/modules/ratelimit/ratelimit.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2257.patch https://github.com/kamailio/kamailio/pull/2257.diff
If you don't want to make it modparam, then better to be increased a bit higher, maybe 32. Same for the number of pipes.
On the other hand, have you looked at pipelimit module? It doesn't have the concept of queues anymore, but they can be replaced with IF conditions in config script, iirc.
@smititelu pushed 1 commit.
f79fb073a0939161ad33dfc8156f1b03b9b2286a ratelimit: increase number of queues and pipes
Updated the default number of pipes and queues to 32.
Thanks, will definitely have a look on the pipelimit module also.
Merged #2257 into master.
From my point of view, this can be backported if needed, is just increasing the capacity of existing features, as the limits were hit in specific deployments, no new feature added. Like we had to do in the past to increase internal buffer sizes to cope with larger values.
-
Daniel-Constantin Mierla -
Stefan Mititelu