<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Kamailio topoh module fails to unmask route headers under following scenario 1. uri_prefix_checks disabled 2. mask_ip configured same as public ip of kamailio host 3. interworking between tcp and udp In this case two record-route headers are added by kamailio for the current host (during tcp to udp conversion). But second record-route is not encoded while sending response to client, but trying to decode second Route on next request from client.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1776
-- Commit Summary --
* topoh: fixed unmask route issue, if maksing fails for one of the routes
-- File Changes --
M src/modules/topoh/th_msg.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1776.patch https://github.com/kamailio/kamailio/pull/1776.diff
I am not really getting the case when deconding fails. Can you paste here a sample sip response that creates such issue?
ACK sip:54.242.101.125;zt-line=zt-GpKmJdbQE06iEAzAhBRmEBXvJBONh0UNE0Gp-jRnJjzmhjv* SIP/2.0 Via: SIP/2.0/TCP 192.168.0.3:59984;branch=z9hG4bK-524287-1---37a2a27a83fd9e73;rport Max-Forwards: 70 Route: sip:54.242.101.125;transport=tcp;r2=on;lr;ftag=04cab258;nat=yes Route: sip:54.242.101.125:5060;r2=on;lr;ftag=04cab258;nat=yes Route: sip:54.242.101.125;zt-line=zt-GpKmJjGi-jOmEqn1JBvNEjISJjzmhjvW8HUW5FZf5A2mhVhfRjUiJB76.sIM5VEA-jvPRT** Contact: sip:919535346001@192.168.0.3:59984;transport=tcp To: sip:919535346001;tag=gK0a97eb53 From: "balajee"sip:919535346001;tag=04cab258 Call-ID: 94385MzgxMjgwMWI1M2YxN2M3MzExYzI3NmMxNzFhODRhMjg CSeq: 1 ACK User-Agent: X-Lite release 5.4.0 stamp 94385 Content-Length: 0
In ACK Topoh module trying to decode second route which is not encoded and fails
It took a bit of time to get back to this one due to winter holidays. The request helped to understand, I will merge the patch. Thanks!
Merged #1776 into master.