<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
We have some user agents that make another subscribe with the same callid, when IP changes. Need to delete the old subscription in that case. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2254
-- Commit Summary --
* presence: add delete_same_subs modparam
-- File Changes --
M src/modules/presence/doc/presence_admin.xml (20) M src/modules/presence/hash.c (34) M src/modules/presence/hash.h (4) M src/modules/presence/presence.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2254.patch https://github.com/kamailio/kamailio/pull/2254.diff
Thanks, looks good. I might be wrong, but one question related to the LM_WARN message: If the parameter is enabled, deletion would be the expected behaviour. Maybe LM_NOTICE or LM_INFO log level is more appropriate?
@smititelu pushed 1 commit.
6d8e0ad3abfc1afb39f9b08a01f0505050f39e03 presence: add delete_same_subs modparam
Updated to LM_NOTICE.
Merged #2254 into master.