Maybe @linuxmaniac can have an additional opinion on this topic. There is a conflict already due to other changes, so cannot be just merged any longer, but the question of this PR is whether to to create or not a pcre group. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/901#issuecomment-271669440

My goal was to integrate kamailio into buildroot (https://buildroot.org/). buildroot allows the user to create its own embedded linux system and the pcre package is not always selected by the user. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/901#issuecomment-272390449

buildroot does not use deb or rpm specs from kamailio tree. To integrate a package to buildroot, I have to define a .mk that explain how to download the source from github and selects the appropriate modules depending on what packages were selected by the user. For example, if the package libmemcached is selected then this package must be built before kamailio and kmemcached module can be compiled: ``` ifeq ($(BR2_PACKAGE_LIBMEMCACHED),y) KAMAILIO_DEPENDENCIES += libmemcached KAMAILIO_GROUPS += kmemcached endif ``` Indeed, you're right, I could use the standard group instead of kstandard. That was my first intent but I realised that it didn't give me enough granularity. For example, in the standard module, kamailio compiles the mod_list_devel which are not necessary as one of the goal of buildroot is to make the most tiny and efficient distribution. But I perfectly understand that you do not want to modify the behavior of the kstandard target as it could impact other users. May I suggest to keep kstandard as it is and define kpcre and kmini targets like this (I think this option is more readable than adding an env variable but this is only my personal opinion)? ``` module_group_kmini=$(mod_list_basic) $(mod_list_extra) \ $(mod_list_db) $(mod_list_dbuid) module_group_kpcre=$(mod_list_pcre) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/901#issuecomment-272406856

OK thanks, I will close this PR and create 2 PRs: one for kmini and another for kpcre -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/901#issuecomment-272449529