You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/971
-- Commit Summary --
* tm: deep cloning of the request for fake environment
-- File Changes --
M src/modules/tm/t_append_branches.c (23) M src/modules/tm/t_reply.c (104) M src/modules/tm/t_reply.h (6) M src/modules/tm/t_suspend.c (24)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/971.patch https://github.com/kamailio/kamailio/pull/971.diff
seems ok to me.
@linuxmaniac, @grumvalski - wondering if you had any time running some tests with the patch, just to have a feeling if you observed any side effect.
I didn't get to review yet, planning to do it during the next days.
I did test with our scenarios, I didn't detect any side effect
Can be merged and backported to 5.0, eventually later to 4.4.
Probably the deep cloning from acc makes no longer sense, I will check that myself, for now should be harmless.
Merged #971.
Sorry for the late feedback. I did try it with some of our suspend scenarios and I haven't noticed side effects. No load though.
-
Daniel-Constantin Mierla -
Federico Cabiddu
-
Victor Seva