<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3018
#### Description
Skip keepalive check if dialog is not local, do the same in case of dialog timeout <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3023
-- Commit Summary --
* dialog: don't do nothing on timeout if dialog is not local * dialog: don't sent ka if dialog is not local
-- File Changes --
M src/modules/dialog/dlg_handlers.c (10) M src/modules/dialog/dlg_req_within.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3023.patch https://github.com/kamailio/kamailio/pull/3023.diff
Thanks for the PR! I would suggest to add a module parameter to control this behaviour, to avoid looking up the socket every time. Also, there are cases when a restart is done to change the ip addresses and if the Routes were with FQDN, it is wanted to continue processing dialogs even if the old ip is not found.
This pull request **introduces 2 alerts** when merging eb80bcb5a2150db1cb3db5c73b159b79f788ae03 into b3314c8b99fb7e9c15aee137e2b9f1fe83881c05 - [view on LGTM.com](https://lgtm.com/projects/g/kamailio/kamailio/rev/pr-b340f981ce01865ae622c56...)
**new alerts:**
* 2 for Expression has no effect
@Riccardo-78 pushed 1 commit.
4cd8dc00eb20068353b2f0b3e38ccebaa31eb79b dialog: add ignore_non_local_dlg parameter
it makes sense, added new parameter (ignore_non_local_dlg) to control this behaviour
Thanks!
I will merge it soon, but then I will rename the new parameter to something like `dlg_filter_mode` and behave on a flags-like value, because it could be useful to reuse it for other purposes, like having a filter mode where dialogs are not loaded from database if they don't have local socket.
Merged #3023 into master.