[kamailio/kamailio] Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)
22 May
2018
22 May
'18
2:55 p.m.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that
apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from
above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev
mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that
apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally against Version 5.1.0
- [x] Related to issue #1168 (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The ims_isc module cannot cope with the fact that asynchronous Response from HSS (Diameter
SAA message) is received as "FAILURE_ROUTE". ims_isc module erroneously assumes,
it is an answer from the AS. Change: added a "firstflag", which makes a
difference between first call (SAA from HSS) and subsequent call (FAILURE ROUTE from AS).
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1538
-- Commit Summary --
* ims_isc: initial fix of issue #1168
* ims_isc: implement regexec for isc_checker_find() for wildcarded PSIs
* ims_isc: fix: use null terminated strings for regex functions
* ims_isc: delete regexec for wildcarded PSIs from isc_checker_find()
* ims_isc: remove KCCVICT tagging
* Merge branch 'devel_rewi_psi' into bugfix_issue_1168
-- File Changes --
M src/modules/ims_isc/ims_isc_mod.c (9)
M src/modules/ims_isc/isc.c (4)
M src/modules/ims_isc/isc.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1538.patch
https://github.com/kamailio/kamailio/pull/1538.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538
22 May
22 May
7:13 p.m.
Should I also send this request as one commit, as it was requested for PR 1539
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-391050303
10:26 p.m.
As described in the pull template: " Each component has a single commit (if not,
squash them into one commit)" - so yes this is generally good.
It makes review easier, we also don't want to include your local development
"history" in our master branch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667
23 May
23 May
1:57 p.m.
Thank you for the Explanation. Now it should be one single commit in the PR, @henningw
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-391306113
29 May
29 May
9:03 a.m.
Hi @christoph-v, ims_isc module is picking default route from scscf.xml file entry i.e.
<DefaultRoute FQDN="hss.net1.test" metric="10"/>
Due to this S-CSCF is forwarding the request to hss.net1.test(port 5065) and not to
application server configured in HSS. Even if I set multiple default routes, ims_isc is
only reading the first <DefaultRoute>. Is there any way to override this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-392661971
2:03 p.m.
Hi @uts09 ,
I think there are several misunderstandings.
1) scscf.xml is read by the cdp module, not by the ims_isc module
1a) The SAR message to the HSS is not triggered by the ims_isc module, but by the
ims_registrar_scscf module, afaik
2) The HSS does not process SIP requests, but it processes DIAMETER
3) Are you sure, you have a Scenario, where you send an Initial INVITE with a PSI in the
Request Line?
4) Have you configured the PSI at the HSS?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-392737579
1 Jun
1 Jun
11:12 a.m.
Merging this one, thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-393803502
11:12 a.m.
Merged #1538.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#event-1657743317
2 Jun
2 Jun
10:25 a.m.
Hello @christoph-v
Below log is from S-CSCF. For some reason S-CSCF is forwarding the packets to
HSS(hss.net1.test:5065) and not to AS. When I run netcat(nc -vv -u -l 5065) on HSS, I am
able to see SIP packets.
Not sure why ims_isc module is sending the packets to HSS. HSS host name is present only
on Bind configuration and scscf.xml file. So I am assuming that S-CSCF is picking
<Defaultroute> parameter from scscf.xml.
```
0(3491) DEBUG: ims_isc [checker.c:456]: isc_checker_find(): About to try
p->s->service_profiles[a].filter_criterai_cnt
0(3491) DEBUG: ims_isc [checker.c:467]: isc_checker_find(): DEBUG ISC: SECOND TIME About
to try p->s->service_profiles_cnt!!
0(3491) DEBUG: ims_isc [checker.c:471]: isc_checker_find(): DEBUG ISC : About to try
p->s->service_profiles
0(3491) DEBUG: ims_isc [checker.c:474]: isc_checker_find(): DEBUG ISC : About to try
public identities
0(3491) DEBUG: ims_isc [checker.c:477]: isc_checker_find(): DEBUG ISC : About to try
WPSI
0(3491) DEBUG: ims_isc [checker.c:319]: isc_check_filter_criteria(): ifc_checker_trigger:
Starting expression check:
0(3491) DEBUG: ims_isc [checker.c:239]: isc_check_spt(): ifc_check_spt: SPT
type 2 -> Method == PUBLISH ?
0(3491) DEBUG: ims_isc [checker.c:241]: isc_check_spt(): ifc_check_spt:
Found method SUBSCRIBE
0(3491) DEBUG: ims_isc [checker.c:340]: isc_check_filter_criteria(): ifc_checker_trigger:
- group compromised, skipping to next group
0(3491) DEBUG: ims_isc [checker.c:239]: isc_check_spt(): ifc_check_spt: SPT
type 2 -> Method == PUBLISH ?
0(3491) DEBUG: ims_isc [checker.c:241]: isc_check_spt(): ifc_check_spt:
Found method SUBSCRIBE
0(3491) DEBUG: ims_isc [checker.c:333]: isc_check_filter_criteria(): ifc_checker_trigger:
- group 1 => 0.
0(3491) DEBUG: ims_isc [checker.c:340]: isc_check_filter_criteria(): ifc_checker_trigger:
- group compromised, skipping to next group
0(3491) DEBUG: ims_isc [checker.c:239]: isc_check_spt(): ifc_check_spt: SPT
type 2 -> Method == SUBSCRIBE ?
0(3491) DEBUG: ims_isc [checker.c:241]: isc_check_spt(): ifc_check_spt:
Found method SUBSCRIBE
0(3491) DEBUG: ims_isc [checker.c:333]: isc_check_filter_criteria(): ifc_checker_trigger:
- group 2 => 1.
0(3491) DEBUG: ims_isc [checker.c:252]: isc_check_spt(): ifc_check_spt: SPT
type 3 -> Header[Event] %= .*presence.* ?
0(3491) DEBUG: ims_isc [checker.c:88]: isc_check_headers(): isc_check_headers: Looking
for Header[Event(22)] .*presence.*
0(3491) DEBUG: ims_isc [checker.c:99]: isc_check_headers(): isc_check_headers: Found
Header[Event(22)] message-summary
0(3491) DEBUG: ims_isc [checker.c:99]: isc_check_headers(): isc_check_headers: Found
Header[Allow-Events(39)] refer, presence, presence.winfo, xcap-diff, conference
0(3491) DEBUG: ims_isc [checker.c:261]: isc_check_spt(): ifc_check_spt: SPT
type 4 -> Session Case == 1 ?
0(3491) DEBUG: ims_isc [checker.c:263]: isc_check_spt(): ifc_check_spt:
Found session_case 1
0(3491) DEBUG: ims_isc [checker.c:326]: isc_check_filter_criteria(): ifc_checker_trigger:
Total compromised, aborting...
0(3491) DEBUG: ims_isc [checker.c:518]: isc_checker_find(): isc_checker_find: MATCH ->
sip:hss.net1.test:5065 () handling 0
0(3491) DEBUG: ims_isc [isc.c:63]: isc_forward(): marking for AS
<sip:hss.net1.test:5065 0(3491) DEBUG:
ims_isc [mark.c:207]: isc_mark_drop_route(): ifc_mark_drop_route: Start ---------
0(3491) DEBUG: ims_isc [mark.c:221]: isc_mark_drop_route(): ifc_mark_drop_route:
---------- End
0(3491) DEBUG: ims_isc [mark.c:293]: isc_mark_write_route(): isc_mark_write_route:
<Route: <sip:hss.net1.test:5065;lr>,
<sip:iscmark@scscf.net1.test;lr;s=1;h=0;d=1;a=7369703a616c69636540696d732e6d6e633030312e6d63633030312e336770706e6574776f726b2e6f7267
0(3491) DEBUG: ims_isc [mark.c:355]: isc_mark_write_psu(): isc_mark_write_psu:
P-Served-User: <sip:alice@net1.test>;sescase=term;regstate=reg
0(3491) DEBUG: ims_isc [mark.c:259]: isc_mark_set(): isc_mark_set: NEW mark
<sip:iscmark@net1.test;lr;s=1;h=0;d=1;a=7369703a616c69636540696d732e6d6e633030312e6d63633030312e336770706e6574776f726b2e6f7267 ```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-394065973
11:03 a.m.
I see P-Served-User: <sip:alice@net1.test>;**sescase=term;regstate=reg** --> this
is not unregistered terminating case and has nothing to do with this pull request. If you
need further support, please write to the mailing list :-)
However: in the logs I see that the ims_isc module has found a MATCH ->
sip:hss.net1.test:5065 () handling 0.
In my humble opinion this means the FQDN hss.net1.test has been sent by the HSS in the IMS
Subscription Info of Alice.
We need a tshark trace from the registration of Alice, when the HSS sends the SAA message
(this should contain the value sip:hss.net1.test:5065 as an address of an application
server). Then we can be sure there is a misconfiguration at the HSS. Now this is only an
assumption.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-394068214
7:30 p.m.
Thank you @miconda for accepting this change. This bug has hindered us to use kamailio
correctly for a long time :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1538#issuecomment-394099573
2368
days inactive
2379
days old
10 comments
4 participants
participants (4)
-
Christoph VALENTIN -
Daniel-Constantin Mierla
-
Henning Westerholt
-
uts09