i'm getting lots of these:
0(13997) WARNING: <core> [usr_avp.c:882]: i: and s: avp name syntax is deprecated!
and didn't find anything about that on tips page.
where is the new avp name syntax explained?
modules_k/avpops/README still has this:
* avp_flags = type_flags [script_flags]; type_flags = 'I' | 'i' | 'S' | 's'; script_flags = 0..255 'I' or 'i' means that the type of avp name is integer (ID) 'S' or 's' means that the type of avp name is string The type flag is mandatory.
-- juha
Hello,
On 05/30/2009 11:23 AM, Juha Heinanen wrote:
i'm getting lots of these:
0(13997) WARNING: <core> [usr_avp.c:882]: i: and s: avp name syntax is deprecated!
and didn't find anything about that on tips page.
where is the new avp name syntax explained?
modules_k/avpops/README still has this:
* avp_flags = type_flags [script_flags]; type_flags = 'I' | 'i' | 'S' | 's'; script_flags = 0..255 'I' or 'i' means that the type of avp name is integer (ID) 'S' or 's' means that the type of avp name is string The type flag is mandatory.
hmm, here is a conflict between S and K I just realized now: - avp name without i: or s: is considered to be string in S and avp alias in K
The solution to keep compatibility is that pv module, which is K specific, will fix the name different that S core.
Cheers, Daniel
On 05/30/2009 11:48 AM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
hmm, here is a conflict between S and K I just realized now:
- avp name without i: or s: is considered to be string in S and avp
alias in K
what is the need for avp aliases if names are always strings?
they are not always strings. As far as I could get it, SR has the old style: - s: ... - string - i: ... - int - no s: or i: - string - $... - avp alias
In K is: s: ... - string - i: ... - int - no s: or i: - avp alias
Cheers, Daniel
Daniel-Constantin Mierla writes:
they are not always strings. As far as I could get it, SR has the old style:
- s: ... - string
- i: ... - int
- no s: or i: - string
- $... - avp alias
if that is true, why is sr complaining:
0(13997) WARNING: <core> [usr_avp.c:882]: i: and s: avp name syntax is deprecated!
deprecation is not a good idea. either drop it or accept it without warning. either is fine with me.
-- juha
On 05/30/2009 12:01 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
they are not always strings. As far as I could get it, SR has the old style:
- s: ... - string
- i: ... - int
- no s: or i: - string
- $... - avp alias
if that is true, why is sr complaining:
0(13997) WARNING: <core> [usr_avp.c:882]: i: and s: avp name syntax is deprecated!
deprecation is not a good idea. either drop it or accept it without warning. either is fine with me.
We cannot drop it, that will break lot of things. The warning should be removed... anyhow it requires a bit of twwaking to get it right with K avp alias style... I will take care in the next days...
Cheers, Daniel
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Daniel-Constantin Mierla writes:
We cannot drop it, that will break lot of things.
like what? why should script write care, how avp names are internally implemented. the only case that comes to mind is if someone has been using two avps that have the same string representation, e.g., i:123 and s:123. even that can be easily fixed by dropping : and use s123.
i have always used int avp names and don't have any problem to convert them to strings.
-- juha
On 05/30/2009 12:15 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
We cannot drop it, that will break lot of things.
like what?
there were modules that work with integer avp names only, there are tools that rely on that. Dropping them at once, without having a transactional release to mark as deprecated/obsolete, will break many things out there and people will not be happy.
Daniel
why should script write care, how avp names are internally implemented. the only case that comes to mind is if someone has been using two avps that have the same string representation, e.g., i:123 and s:123. even that can be easily fixed by dropping : and use s123.
i have always used int avp names and don't have any problem to convert them to strings.
-- juha
-
Daniel-Constantin Mierla -
jh＠tutpro.com