#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4187
#### Description core: tcp_send_timeout applied for outbound connections You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4234
-- Commit Summary --
* core: tcp_send_timeout applied for outbound connections
-- File Changes --
M src/core/tcp_main.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4234.patch https://github.com/kamailio/kamailio/pull/4234.diff
@sergey-safarov pushed 1 commit.
26501c13803eb4a3f0fa2f623f8bed0fde639eb5 core: tcp_send_timeout applied for outbound connections
sergey-safarov left a comment (kamailio/kamailio#4234)
Question. Is required output next message using `LM_DBG` ``` LM_INFO("Set TCP_USER_TIMEOUT=%d ms\n", optval); ```
henningw left a comment (kamailio/kamailio#4234)
Thanks for the PR. Regarding the question about the "Set TCP_USER_TIMEOUT" log, in my opinion its ok to keep it with INFO for now, also to inform users about it, as in the past it was not applied. If its too noisy we can always set to DBG later one.
sergey-safarov left a comment (kamailio/kamailio#4234)
I have tested PR on another host and see this message generated too often ``` LM_INFO("Set TCP_USER_TIMEOUT=%d ms\n", optval); ``` On this server, many SIP trunks and a dispatcher module are used, which establish connections via TCP transport. It looks like will be fine to use `LM_DBG`.
@sergey-safarov pushed 1 commit.
e2a6fb4d8929e5cecc93e0c889b6d6b8c80dc80d core: tcp_send_timeout applied for outbound connections
sergey-safarov left a comment (kamailio/kamailio#4234)
I have decreased log level from the `LM_INFO` to `LM_DBG`.
miconda left a comment (kamailio/kamailio#4234)
Thanks!
Merged #4234 into master.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
sergey-safarov