<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
While testing this module, I've seen it doesn't trace in-dialog ACKs. Found this old maillist discussion: https://lists.kamailio.org/pipermail/sr-users/2015-June/088731.html Added a condition to trace also the in-dialog ACKs. Is it ok to keep it as default or should I guard it via a modparam?
Thanks, Stefan You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3206
-- Commit Summary --
* siptrace: Trace in-dialog ACK
-- File Changes --
M src/modules/siptrace/siptrace.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3206.patch https://github.com/kamailio/kamailio/pull/3206.diff
Thanks for the pull-request. This is a small patch and it uses similar dialog callbacks as already used for the other messages. In my opinion we do need a modparam for that as it should trace all messages belonging to the dialog. But lets wait if there are maybe other comments.
@smititelu pushed 1 commit.
cfa7e20d2947b5edab409032e230cffb0d0752fb siptrace: Trace in-dialog ACK and dialog spirals
Updated PR. Besides in-dialog ack tracing, I've also added tracing of spiraled dialogs. Guarded behavior via 2 new modparams.
Merged #3206 into master.
Thanks, merged. I will do one commit to enable the parameter it by default, similar to the setting in the dialog module.