Hello,

we should replace memmem with ser_memmem and remove _GNU_SOURCE for this case.

In the future we can look to replace strndup with an embedded version as well. tls module is a main one, but still compiles separately and is packaged on its own.

Cheers, Daniel

On 09/04/14 08:06, Juha Heinanen wrote:

daniel,

thanks for your reply. i started a new thread on _GNU_SOURCE.

tcp_main.c includes io_wait.h, which in turn defines _GNU_SOURCE:

#define _GNU_SOURCE /* for POLLRDHUP on linux */

_GNU_SOURCE is also included by tls module, which can be considered to be part of "core":

#define _GNU_SOURCE 1 /* Needed for strndup */

is it possible to get rid of these two _GNU_SOURCE dependencies?

if not, then _GNU_SOURCE version of memmem can be freely used in all modules and we can get rid of ser_memmem.

--- juha

---

sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev