[kamailio] kamailio sending update ccr request instead of terminate request for initial ccr response having final_unit_action flag. (#467)
If final_unit_action flag is set in initial ccr response, kamailio need to send terminate request after time out but it is sending update request.but it is fine for intermediate requests. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/467
-- Commit Summary --
* If final_unit_action flag is set in initial ccr response, kamailio need to send terminate request after time out but it is sending update request.but it is fine for intermediate requests.
-- File Changes --
M modules/ims_charging/ims_ro.c (3) M modules/ims_charging/ro_session_hash.h (1) M modules/ims_charging/ro_timer.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/467.patch https://github.com/kamailio/kamailio/pull/467.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/467
Hopefully @jaybeepee, @richardgood or @ngvoice can check and confirm that the patch is good.
If all ok, I would like to merge the patch manually because the commit message is not properly formatted -- I can take care of the merge provided IMS devs are fine with the patch.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/467#issuecomment-170050837
@richardgood @jaybeepee : Looks good to me, what do you think? Thanks!
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/467#issuecomment-170337378
I am happy with this. you can push ;)
Cheers and thanks for the contribution!
On Sun, 10 Jan 2016 at 13:36 ng-voice GmbH notifications@github.com wrote:
@richardgood https://github.com/richardgood @jaybeepee https://github.com/jaybeepee : Looks good to me, what do you think? Thanks!
—
Reply to this email directly or view it on GitHub https://github.com/kamailio/kamailio/pull/467#issuecomment-170337378.
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Closed through commit 581912f5ed117bb56087668aa7ac60a7b667d525.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/467#issuecomment-170564906
Closed #467.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/467#event-511144860
-
Daniel-Constantin Mierla -
DileepNunna
-
Jason Penton -
ng-voice GmbH