Hello can you please remove the uncessary condition if (c==0 || c== 1) {} and leave only the body of that condition please and remove also the unused c variable. we dont need it.

should be like this

``` int tps_reappend_via_separate_header(sip_msg_t *msg, tps_data_t *ptsd, str *hbody) { str hname = str_init("Via"); int i; str sb; char *p = NULL;

if(hbody==NULL || hbody->s==NULL || hbody->len<=0 || hbody->s[0]=='\0') return 0;

sb.len = 1; p = hbody->s; for(i=0; i<hbody->len-1; i++) { if(hbody->s[i]==',') { if(sb.len>0) { sb.s = p; if(sb.s[sb.len-1]==',') sb.len--; if(tps_add_headers(msg, &hname, &sb, 0)<0) { return -1; } } sb.len = 0; p = hbody->s + i + 1; } sb.len++; }

if(sb.len>0) { sb.s = p; if(sb.s[sb.len-1]==',') sb.len--; if(tps_add_headers(msg, &hname, &sb, 0)<0) { return -1; } }

return 0; }

```

Thanks.

@emvondo pushed 1 commit.

674330d33ca0c0ab6fa9e989300cec92734e9e1d topos: enable multiple Via values in separate via header

@emvondo thanks for the pull request. In the issue #3216 you are also discussing the Route and Record-Route headers. Are you planning to add also individual parameters for this headers in the PR? Maybe it make sense to have a one parameter for all three headers? Just trying to understand the direction of it.

Ok, sounds good. As you probably know, the documentation (XML docbook) needs to be extended as well, to be ready for the merge. But its usually a good idea to do that at the end after all code changes were done.

Ok, sounds good. As you probably know, the documentation (XML docbook) needs to be extended as well, to be ready for the merge. But its usually a good idea to do that at the end after all code changes were done.

Thanks for feedback.

i pushed updates for Via , Record-Route and Route header.

@emvondo pushed 1 commit.

4816a86bf6fe82d8bf20c31909f5db6205added4 topos: disable multiple comma separated values in One Single Via, Record-Route or Route header

The name of the parameter `separate_header_values` should be changed to `header_mode` to be even more generic and reused if anything else related to header management needs to be added in the future (e.g., add Via before or after Route).

From implementation point of view, the current solution is "good enough" because it is doing a basic split on comma, working with the common format seen for these headers. Otherwise, at least the `Record/-Route` can have comma in its value, being defined as `name-addr` by grammar and in the eventuality of a display name, comma is allowed inside. Not sure if Via is allowed to have quoted value parameter, because I think inside it is also allowed to have comma.

Anyhow, given that this commit adds this behaviour for particular deployments when some UA doesn't support headers with multiple comma separated values, I am fine to merge the implementation as it is, after renaming the parameter.

The name of the parameter `separate_header_values` should be changed to `header_mode` to be even more generic and reused if anything else related to header management needs to be added in the future (e.g., add Via before or after Route).

From implementation point of view, the current solution is "good enough" because it is doing a basic split on comma, working with the common format seen for these headers. Otherwise, at least the `Record/-Route` can have comma in its value, being defined as `name-addr` by grammar and in the eventuality of a display name, comma is allowed inside. Not sure if Via is allowed to have quoted value parameter, because I think inside it is also allowed to have comma.

Anyhow, given that this commit adds this behaviour for particular deployments when some UA doesn't support headers with multiple comma separated values, I am fine to merge the implementation as it is, after renaming the parameter.

Thanks for feedback @miconda changes done.

Thank you all, merged.