i'm thinking to add method mask to xlog module. when xlog() is called, nothing happens if method of request or reply is included in the mask. the mask could be set at run rime via an rpc command and would default to 0.
using the mask, it would be easy, for example, to prevent logging of OPTIONS requests without a need to add if statements to the script.
any comments?
-- juha
On 7/15/10 8:22 AM, Juha Heinanen wrote:
i'm thinking to add method mask to xlog module. when xlog() is called, nothing happens if method of request or reply is included in the mask. the mask could be set at run rime via an rpc command and would default to 0.
using the mask, it would be easy, for example, to prevent logging of OPTIONS requests without a need to add if statements to the script.
any comments?
$rm should return method type as integer when used in integer operations. This together with a shared variable (e.g., $shv(x) -- they can be changed at runtime via mi/rpc) and bitwise 'and' can be used to achieve what you want in your config.
Introducing the check inside the module will make the 'if' to be executed for each xlog function. Personally I would prefer to avoid introducing in the code all kind of filtering conditions, especially if they are not very common.
Cheers, Daniel
Daniel-Constantin Mierla writes:
$rm should return method type as integer when used in integer operations. This together with a shared variable (e.g., $shv(x) -- they can be changed at runtime via mi/rpc) and bitwise 'and' can be used to achieve what you want in your config.
without if statements?
Introducing the check inside the module will make the 'if' to be executed for each xlog function. Personally I would prefer to avoid introducing in the code all kind of filtering conditions, especially if they are not very common.
no problem. i can make a private version of xlog module that includes this one extra c if statement.
-- juha
-
Daniel-Constantin Mierla -
Juha Heinanen