<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description * Make parser error logs as debug avoiding excessive logging for negative HTTP replies. The issue was discussed here: https://lists.kamailio.org/pipermail/sr-users/2020-February/108232.html
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2226
-- Commit Summary --
* Merge branch 'master' of github.com:nferreyra/kamailio * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * core: log parser error messages with debug level
-- File Changes --
M src/core/parser/msg_parser.c (2) M src/core/parser/parse_fline.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2226.patch https://github.com/kamailio/kamailio/pull/2226.diff
Thanks for the pull request. Well, these are the core parsing functions, that are used for all kind of messages. I don't like to just change it to DBG, because it suppress all kind of parsing errors then. You pull request contains also three unrelated merge commits. I think there should be another solution possible.
Those message can be aready skipped by setting `core_log` global parameter.
* https://www.kamailio.org/wiki/cookbooks/5.3.x/core#corelog
No need to force them to a specific log level.
As for topos, I pushed a patch to catch http replies. Try with:
* https://github.com/kamailio/kamailio/commit/fad795648f8cbf12cc099dea18092ff7...
Closed #2226.
@miconda thank you for the corelog reference, it was there all the time and I didn't rtfm. You topos patch is working fine. For the sake of consistency, shouldn't a similar patch be applied to topoh? Thank you.
topoh got a similar patch, if you can test that module as well and report the results, it would be great.