#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally
#### Description Changes from Sipwise flavor: - refresh_pubruri_avps_flag: if enabled, this message flag indicates whether to refresh R-Uri from avps before sending the PUBLISH requests. - improvement for use_pubruri_avps: use locking to avoid crashes since we are using shared memory - local_identity_dlg_var: reporting dialog-information will use the value of the dialog variable if exists
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3143
-- Commit Summary --
* pua_dialoginfo: refresh_pubruri_avps_flag * pua_dialoginfo: use lock when use_puburi_avps is set * pua_dialoginfo: local_identity_dlg_var
-- File Changes --
M src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml (39) M src/modules/pua_dialoginfo/pua_dialoginfo.c (113) M src/modules/pua_dialoginfo/pua_dialoginfo.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3143.patch https://github.com/kamailio/kamailio/pull/3143.diff
@linuxmaniac pushed 3 commits.
dce8a7cf24f7f3a6d0a281a9f2953aea0fb6a901 pua_dialoginfo: refresh_pubruri_avps_flag 209d352975da0d14c9b7ee4706e4ec13dec65617 pua_dialoginfo: use lock when use_puburi_avps is set 5715c0a81fc25ad98566202efef46e41175727ec pua_dialoginfo: local_identity_dlg_var
Fine to merge from my point of view!
Just a note that there might be some design issue with dialog vars, considering some reports on the tracker, but this has to be analyzed separately, not being something specific to PR, but impacts it.
Merged #3143 into master.