[kamailio] usrloc: really do the ignore location record if it's a non-local socket (#306)
* When usrloc loading location records from database, and if the socket of the record is not matched in kamailio's listening socket list, It only throws LM_ERR ignoring message only but still store into memory. should `return 0` as well.
* And the message typo sometimes confused people to distinguish that kamailio is "sipping" the record (redirct) or "skipping" the record. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/306
-- Commit Summary --
* usrloc: fix ignore location record if it's a non-local socket * usrloc: fixed typo in skipping record LM_ERR msg
-- File Changes --
M modules/usrloc/udomain.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/306.patch https://github.com/kamailio/kamailio/pull/306.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306
For the first patch -- the behaviour is like that on purpose, because one can have replicated location records via database and the case can be that register was processed by one server and records are loaded by another server, there being different IPs for each servers. Another situation is changing the ip address and restarting kamailio. If there is no NAT involved, the location records work fine when that socket field is ignored.
If you want to restrict this behaviour and not allow loading those records, then add a module parameter to control it.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306#issuecomment-135316447
thanks, I see.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306#issuecomment-135317361
I added it as a module parameter.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306#issuecomment-135342006
Thanks, it will be merged.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306#issuecomment-135395484
Merged #306.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/306#event-393915565
-
Daniel-Constantin Mierla -
zxcpoiu