You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/55
-- Commit Summary --
* presence_dialoginfo : optionally send dummy dialog
-- File Changes --
M modules/presence_dialoginfo/doc/presence_dialoginfo_admin.xml (25) M modules/presence_dialoginfo/notify_body.c (47) M modules/presence_dialoginfo/presence_dialoginfo.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/55.patch https://github.com/kamailio/kamailio/pull/55.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55
this seems to also affect astra phones besides Bria
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#issuecomment-71890581
You can merge it to master branch.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#issuecomment-71906668
Merged #55.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#event-226348880
Hi Daniel,
can i backport to 4.2 ? would like to fix astra / bria - blf issues
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#issuecomment-71907028
First send a dedicated email on sr-dev with details about the issue and the fix, proposing to backport. It is good to get the eyes of other people on the changes and the opinions on the fix. I would like to avoid breaking in any way the expectations from a stable branch. If the opinions on sr-dev are for backporting, then I am fine as well.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#issuecomment-71909398
Hi List,
some sip clients like Bria and some sip phones like Astra expect a <dialog-info><dialog></dialog></dialog-info> on the NOTIFY message sent.
presence sends a NOTIFY after the SUBSCRIBE with NULL body if it doesn't find the presentity.
the patch already in master allows to configure the creation of a dummy dialog to be sent when presence doesn't find the presentity.
this behavior was only observed in dialog subscriptions so the patch was made against presence_dialoginfo.
the new param force_dummy_dialog defaults to 0 to preserve existing behavior.
does anyone have anything against backporting this to 4.2 ?
Best
________________________________ From: sr-dev [sr-dev-bounces@lists.sip-router.org] on behalf of Daniel-Constantin Mierla [notifications@github.com] Sent: Wednesday, January 28, 2015 12:27 PM To: Kamailio Devel List Subject: Re: [sr-dev] [kamailio] presence_dialoginfo : optionally send dummy dialog (#55)
First send a dedicated email on sr-dev with details about the issue and the fix, proposing to backport. It is good to get the eyes of other people on the changes and the opinions on the fix. I would like to avoid breaking in any way the expectations from a stable branch. If the opinions on sr-dev are for backporting, then I am fine as well.
— Reply to this email directly or view it on GitHubhttps://github.com/kamailio/kamailio/pull/55#issuecomment-71909398.
Hi List,
some sip clients like Bria and some sip phones like Astra expect a <dialog-info><dialog></dialog></dialog-info> on the NOTIFY message sent.
presence sends a NOTIFY after the SUBSCRIBE with NULL body if it doesn't find the presentity.
the patch already in master allows to configure the creation of a dummy dialog to be sent when presence doesn't find the presentity.
this behavior was only observed in dialog subscriptions so the patch was made against presence_dialoginfo.
the new param force_dummy_dialog defaults to 0 to preserve existing behavior.
does anyone have anything against backporting this to 4.2 ?
Best
________________________________ From: sr-dev [sr-dev-bounces@lists.sip-router.org] on behalf of Daniel-Constantin Mierla [notifications@github.com] Sent: Wednesday, January 28, 2015 12:27 PM To: Kamailio Devel List Subject: Re: [sr-dev] [kamailio] presence_dialoginfo : optionally send dummy dialog (#55)
First send a dedicated email on sr-dev with details about the issue and the fix, proposing to backport. It is good to get the eyes of other people on the changes and the opinions on the fix. I would like to avoid breaking in any way the expectations from a stable branch. If the opinions on sr-dev are for backporting, then I am fine as well.
— Reply to this email directly or view it on GitHubhttps://github.com/kamailio/kamailio/pull/55#issuecomment-71909398.
You should send a new email, with an explicit subject -- that is what I meant with a 'dedicated' email -- keeping discussion on this thread is not highlighting the purpose. This thread here is marked as closed.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55#issuecomment-71911890
-
Daniel-Constantin Mierla -
lazedo
-
Luis Azedo