<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> While starting kamailio or reloading the routes, if the same carrier/domain pairs do not have any route with a probability other than 0 (zero) then an error log will be printed on the screen. Besides, the log "invalid dice_max value" in the cr_func.c has been made more clear.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1232
-- Commit Summary --
* carrierroute: warning for the same carrier/domain having routes with only 0 probability
-- File Changes --
M src/modules/carrierroute/cr_db.c (34) M src/modules/carrierroute/cr_db.h (5) M src/modules/carrierroute/cr_func.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1232.patch https://github.com/kamailio/kamailio/pull/1232.diff
lbalaceanu commented on this pull request.
@@ -352,6 +353,7 @@ int load_route_data_db(struct route_data_t * rd) {
} } int n = 0; + boolean query_done = true;
Please change query_done to false here and adapt the code accordingly. The name of the variable should reflect the value it holds.
@hdikme pushed 2 commits.
4aaa0af carrierroute: warning for the same carrier/domain having routes with only 0 probability c275210 Merge branch 'master' of https://github.com/hdikme/kamailio
Following the commit based on your comment, your comment "Please change query_done to false here and adapt the code accordingly. The name of the variable should reflect the value it holds." disappeared but i have done the requested changes.
Closed #1232.
@hdikme - the comment of @lbalaceanu was on the code of the patch and github hides it, you need to press `Show outdated` in the right side of @lbalaceanu's comment above here.