<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Add global config var
``` enable_tls_thread=1 #0 | 1 | 2 ```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3745
-- Commit Summary --
* step-1 * step-2 * step-3
-- File Changes --
M src/core/cfg.lex (2) M src/core/cfg.y (5) M src/core/globals.h (1) M src/core/rthreads.h (19) M src/main.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3745.patch https://github.com/kamailio/kamailio/pull/3745.diff
Looks like we were working in parallel and I pushed a commit to add the global parameter with the name `tls_threads_mode` (internal global variable `ksr_tls_threads_mode`). I also replied to the email on sr-dev where you asked for assistance on it. Maybe you can amend your code to use the global parameter that I added because I consider it to reflect better its scope.
Closed #3745.
Reopened #3745.
Looks like we were working in parallel
Done - please check
Closed #3745.
@space88man thanks for the work on this topic. It is great that there is then a way from version 5.7.4 and forward to restore the previous behaviour, especially in the stable branch.