You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3298
-- Commit Summary --
* Typos: withing → within
-- File Changes --
M doc/tutorials/presence/cfg/full_ps.cfg (2) M doc/tutorials/presence/cfg/ps.cfg (2) M etc/kamailio.cfg (2) M etc/sip-router.cfg (2) M misc/examples/ims/pcscf/kamailio.cfg (2) M misc/examples/kamailio/acc-mysql.cfg (2) M misc/examples/kamailio/nathelper.cfg (2) M misc/examples/kemi/kamailio-basic-kemi-jsdt.js (2) M misc/examples/kemi/kamailio-basic-kemi-lua.lua (2) M misc/examples/kemi/kamailio-basic-kemi-native.cfg (2) M misc/examples/kemi/kamailio-basic-kemi-python.py (2) M misc/examples/kemi/kamailio-basic-kemi-python3s.py (2) M misc/examples/kemi/kamailio-basic-kemi-sqlang.sq (2) M misc/examples/mixed/kamailio-minimal-anycast.cfg (2) M misc/examples/mixed/kamailio-minimal-proxy.cfg (2) M misc/examples/mixed/nathelper.cfg (2) M misc/examples/pkg/kamailio-basic.cfg (2) M misc/examples/pkg/kamailio-oob.cfg (2) M misc/examples/pkg/sip-router-basic.cfg (2) M misc/examples/pkg/sip-router-oob.cfg (2) M misc/examples/presence/full-no-failover.cfg (2) M misc/examples/presence/no-db.cfg (2) M misc/examples/webrtc/kamailio-default-websocket.cfg (2) M misc/examples/webrtc/websocket.cfg (2) M src/modules/app_java/kamailio_java_folder/java-untested/Kamailio.java (2) M src/modules/cnxcc/example/kamailio-cnxcc.cfg (2) M src/modules/db_cassandra/kamailio_cassa.cfg (2) M src/modules/db_text/README (2) M src/modules/db_text/doc/db_text.cfg (2) M src/modules/dispatcher/README (2) M src/modules/dispatcher/doc/dispatcher.cfg (2) M src/modules/sca/README (2) M src/modules/sca/doc/sca.cfg (2) M src/modules/websocket/README (2) M src/modules/websocket/doc/websocket_admin.xml (2) M src/modules/xprint/xp_lib.c (2) M test/unit/5.cfg (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3298.patch https://github.com/kamailio/kamailio/pull/3298.diff
Thank you for the pull-request. Two notes: Could you please split the PR into several commits as indicated in our contributing guidelines? Like one commit per module (cassandra, xprint etc..), one for the KEMI, one for the cfg examples, one for the "core" if necessary etc.. Furthermore, please do not change the README files for the modules. This files are auto-generated from the XML files in the docs, so its sufficient to change it there. Regarding changes to this PR, you can git force-push, or just close and create a new one, what is easier for you.
The changes are performed by calling
sed -i "s/withing/within/" `git grep -l withing` && git add . && git commit …
The process proposed by you does cost time to follow, but does not solve real problems in the concrete case. I am not going to create separate commit for each module. I find no XML files containing `withing` (or rather: I find only one such file and applying a change both in it and in the generated README file is OK).
The reasoning behind the policy to have one commit per module or component is to allow tracking of changes and also back-porting/cherry-picking of changes per module towards stable releases. This is not possible if its all in one commit. The split commits can be probably also done by some scripting. If you are not able to do it, we can not apply this PR unfortunately, maybe somebody else can pick it up then.
I am not convinced that in this particular case splitting the commit does solve real problems and I am not going to split it myself.
Closed #3298.
Ok, sure
The spelling fixes were pushed to git master manually
-
Henning Westerholt -
Дилян Палаузов