In modules/cdp/diameter.h and modules/acc/diam_message.h, this directive still exists :
```#error BIG endian detected!!```
Meanwhile in modules/auth_diameter/diameter_msg.h, for example, this directive was removed in 5.0 release. Is there any reason to leave this directive present in these 2 headers?
The build system is Alpine Linux s390x which is big endian.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1068
-- Commit Summary --
* modules/{acc,cdp}: allows big endian build
-- File Changes --
M src/modules/acc/diam_message.h (1) M src/modules/cdp/diameter.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1068.patch https://github.com/kamailio/kamailio/pull/1068.diff
auth_diameter had a different implementation than cdp. Maybe @ngvoice, @jaybeepee or @vingarzan can comment if cdp is safe for big endian.
Going to merge this PR, if there will be issue (as now is not allowed to run on big endian), then it can be reverted or fixed differently.
Merged #1068.
Thank you, I will keep an eye on this too.