- added a new config param - ipsec_reuse_server_port - reuse or not PCSCF server port for UA Re-registration. - added description for the new parameter in ims_ipsec_pcscf_admin.xml. parameter ipsec_reuse_server_port. - in ipsec_forward() add supported and require secagree headers only for Register reply with code 200. - in fill_contact() for Request messages set received host, port and proto from request uri if alias is presented.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2164
-- Commit Summary --
* ims_ipsec_pcscf: new config param for ipsec
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (192) M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (22) M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2164.patch https://github.com/kamailio/kamailio/pull/2164.diff
Hi all, I am still waiting for a review more than a month.
Thanks!
Hi, sorry I already looked into it some time ago. I will look again to it today and merge it.
________________________________ From: sr-dev sr-dev-bounces@lists.kamailio.org on behalf of alexyosifov notifications@github.com Sent: Monday, January 13, 2020 10:49:20 AM To: Kamailio Devel List sr-dev@lists.sip-router.org Cc: Subscribed subscribed@noreply.github.com Subject: Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: new config param for ipsec (#2164)
Hi all, I am still waiting for a review more than a month.
Thanks!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/kamailio/kamailio/pull/2164?email_source=notifications&email_token=ABO7UZLPYFXG5QHB4JE3H5TQ5Q2KBA5CNFSM4JVFODH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIYCTWY#issuecomment-573581787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABO7UZL6ZI6U6NM2YOMUJQ3Q5Q2KBANCNFSM4JVFODHQ.
Merged #2164 into master.
Thanks again, merged.